Add search box and platform field to coupon dashboard#2187
Conversation
rename assets to UUID-based naming
KatelynGit
changed the title
There was a problem hiding this comment.
Pull request overview
Updates a Superset table chart used in the Coupons dashboard to surface a new platform dimension and enable in-table search, aligning with hq#9480’s request to improve coupon exploration.
Changes:
- Added
platformto the chart’sgroupbyfields. - Enabled the table’s built-in search (
include_search: true). - Updated exported chart params (including removal of some existing table params).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| all_columns: [] | ||
| allow_render_html: true | ||
| annotation_layers: [] | ||
| color_pn: true | ||
| comparison_color_scheme: Green | ||
| comparison_type: values | ||
| conditional_formatting: [] |
There was a problem hiding this comment.
annotation_layers and comparison_color_scheme were removed from the chart params in this change, which can unintentionally reset chart defaults (e.g., comparison coloring / annotations) and makes this diff larger than the stated goal (add platform + search). If the behavior should remain unchanged, please re-add these keys with their previous values; otherwise, call out the intentional behavior change in the PR description so reviewers/QA know to validate it.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Already addressed in commit 9abb33b — annotation_layers: [] and comparison_color_scheme: Green have been restored.
| include_search: true | ||
| order_by_cols: [] | ||
| order_desc: true | ||
| percent_metric_calculation: row_limit |
There was a problem hiding this comment.
This update drops order_desc: true and server_page_length: 10 from the table chart params. That can change default sort direction and pagination behavior in the dashboard UI. If those behaviors should stay the same, please restore these params to their previous values and re-export/normalize the asset; if the change is intentional, document the intended new behavior and ensure QA validates it.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Restored annotation_layers, comparison_color_scheme, order_desc: true, and server_page_length: 10 in commit 9abb33b. The diff now only contains the intended additions: platform in groupby, include_search: true, and conditional_formatting: [] (added by normalize).
…server_page_length to coupon chart Agent-Logs-Url: https://github.com/mitodl/ol-data-platform/sessions/c578e8bc-4b15-4081-8a41-b6a0ab8b8f28 Co-authored-by: KatelynGit <134744245+KatelynGit@users.noreply.github.com>
What are the relevant tickets?
https://github.com/mitodl/hq/issues/9480
Description (What does it do?)
Add search box and platform field to coupon dashboard/chart
How can this be tested?
review qa and yaml